From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 20 Jan 2008 19:20:54 GMT
Subject: Re: [PATCH] git-fsck: report missing author/commit line in a commit as an error
Message-ID: <alpine.LSU.1.00.0801201918260.5731@racer.site>
In-Reply-To: <12008555922208-git-send-email-mkoegler@auto.tuwien.ac.at>

Hi,

On Sun, 20 Jan 2008, Martin Koegler wrote:

> +	if (!commit->date)
> +		return objerror(&commit->object, "invalid author/commiter line in %s",

s/commiter/committer/

It makes me wonder, though, if that's correct.  AFAICT it is the committer 
date, and the rest of the line _might_ be just fine.

Why not be less intrusive and just change the printf() into a return 
objerror(), like the commit message suggests?

Ciao,
Dscho