Re: [PATCH 2/2] filter-branch: work correctly with ambiguous refnames
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 6, 2008, 09:14 UTC
- Message-ID
- <alpine.LSU.1.00.0801060912310.10101@racer.site>
- In-Reply-To
- <7v8x337jgn.fsf@gitster.siamese.dyndns.org>
Hi Junio,
On Sat, 5 Jan 2008, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > In any case, from a cursory look I like the 2 patches (except for the > > curly brackets around the single-line "else" clause, but I know your > > opinion about this, so I will not object). > > And obviously I care more about correctness, so I'd appreciate a review > with non cursory look if you have time.
I will be in the train for 5.5 hours tomorrow, and hope to do a less cursory review then.
Ciao, Dscho