Re: [PATCH 2/2] filter-branch: work correctly with ambiguous refnames

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2008, 02:53 UTC
Message-ID: <7v8x337jgn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0801060154150.10101@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> In any case, from a cursory look I like the 2 patches (except for the 
> curly brackets around the single-line "else" clause, but I know your 
> opinion about this, so I will not object).

I care more about consistency across codebase than my own preference [*1*]. I just picked the style the kernel folks seem to use (see their Documentation/CodingStyle), only because (1) there seem to be people familiar with it, and (2) I am not particularly interested myself in wasting time arguing over which style is superiour. I just had to pick one and that was the one I happened to have at hand.

And obviously I care more about correctness, so I'd appreciate a review with non cursory look if you have time.

[Footnote]

*1* I favoring shorter code over consistency between when-true and when-false clauses. IOW, I do not like having to have {} around a single statement in else clause when if clause needs {} around it.