Re: [PATCH] Fix 'git commit -a' in a newly initialized repository

From: Nicolas Pitre <nico@cam.org>
Date: Feb 22, 2007, 20:54 UTC
Message-ID: <alpine.LRH.0.82.0702221550290.27932@xanadu.home>
In-Reply-To: <Pine.LNX.4.63.0702222140360.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On Thu, 22 Feb 2007, Johannes Schindelin wrote:

Show 7 quoted lines

> Hi,
> 
> On Thu, 22 Feb 2007, Fredrik Kuivinen wrote:
> 
> > +		die 'nothing to commit (use "git add file1 file2" to include for commit)'
> 
> Would it not make more sense to tell the user about "git add ."?

Isn't what the patch does? IMHO it looks just like the empty commit message which is good.

Show 5 quoted lines

> Maybe 
> together with a hint about .gitignore?
> 
> This error message is important. The most likely recipients are total git 
> newsters, and we really should try to help them here.

Sure. But to really help newsters it is better _not_ to talk about .gitignore at all. It certainly won't exist at that point anyway.

Nicolas