Re: [PATCH] Fix 'git commit -a' in a newly initialized repository

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 22, 2007, 20:59 UTC
Message-ID: <Pine.LNX.4.63.0702222157000.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <alpine.LRH.0.82.0702221550290.27932@xanadu.home>

Hi,

On Thu, 22 Feb 2007, Nicolas Pitre wrote:

Show 10 quoted lines

> On Thu, 22 Feb 2007, Johannes Schindelin wrote:
> 
> > On Thu, 22 Feb 2007, Fredrik Kuivinen wrote:
> > 
> > > +		die 'nothing to commit (use "git add file1 file2" to include for commit)'
> > 
> > Would it not make more sense to tell the user about "git add ."?
> 
> Isn't what the patch does?  IMHO it looks just like the empty commit 
> message which is good.

I wanted to get at the "." thing. You know, when I start a project with git, there are usually some files there already. Provided I have a .gitignore there, I can just say "git add ." and be done.

But maybe that is _not_ common practice?

Show 7 quoted lines

> > Maybe together with a hint about .gitignore?
> > 
> > This error message is important. The most likely recipients are total 
> > git newsters, and we really should try to help them here.
> 
> Sure.  But to really help newsters it is better _not_ to talk about 
> .gitignore at all.  It certainly won't exist at that point anyway.

Hmm. That is a really good point. Hmmm. I think you're right.

Ciao, Dscho