Re: [PATCH 2/8] revert: Make "commit" and "me" local variables
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- May 13, 2011, 21:40 UTC
- Message-ID
- <alpine.LNX.2.00.1105131715240.6881@iabervon.org>
- In-Reply-To
- <1305100822-20470-3-git-send-email-artagnon@gmail.com>
On Wed, 11 May 2011, Ramkumar Ramachandra wrote:
Show 13 quoted lines
> @@ -583,10 +589,12 @@ static int read_and_refresh_cache(const char *me)
> static int revert_or_cherry_pick(int argc, const char **argv)
> {
> struct rev_info revs;
> + struct commit *commit;
> + const char *me;
> int res;
>
> git_config(git_default_config, NULL);
> - me = action == REVERT ? "revert" : "cherry-pick";
> + me = (action == REVERT ? "revert" : "cherry-pick");
> setenv(GIT_REFLOG_ACTION, me, 0);
> parse_args(argc, argv);Later in the series, you remove everything related to "me" that you add here, having modified it once in the middle. Just go to
setenv(GIT_REFLOG_ACTION, action == REVERT ? "revert" : "cherry-pick");
and remove "me" from this function in this patch. For that matter, squashing together the "opts" patch and this one would probably make them make more sense: there's not much benefit to getting rid of some globals when other globals remain that matter for the same reason. It also fixes the annoyance that each place you introduce "me" in this patch needs to be changed later in the series.
-Daniel *This .sig left intentionally blank*