Re: git-mail-commits (Re:What's a good setup for submitting patches to the list properly?)

From: Julian Phillips <julian@quantumfyre.co.uk>
Date: Aug 25, 2009, 00:06 UTC
Message-ID: <alpine.LNX.2.00.0908250102580.28400@reaper.quantumfyre.co.uk>
In-Reply-To: <20090823234108.GB3526@vidovic>

On Mon, 24 Aug 2009, Nicolas Sebrecht wrote:

Show 18 quoted lines

> The 24/08/09, Julian Phillips wrote:
>> On Sun, 23 Aug 2009, Christian Couder wrote:
>>
>> Using the awsome power of git I have managed to extract it from my random
>> tools private repo to here as if I had written it to be a separate entity
>> from the start:
>>
>> git://git.q42.co.uk/mail_commits.git
>> (gitweb: http://git.q42.co.uk/w/mail_commits.git)
>
> Thanks a lot.
>
>> If it would be considered useful, then I can also create a patch to add
>> it to contrib
>
> I think it worth. That said, I would first add some config options like
> mail-commits.cc (not reviewed that much yet) to be a bit more consistent
> with the send-email program. I would also add README and INSTALL files.

Yeah ... it would be nice to have more options settable via config. Some form of documentation would also be a good idea, and I would like to tidy the code up a bit. Kinda sort on tuits just at the moment though ... :(

> Could you please consider to place your code under GPLv2?

I have added a license statement.

-- 
Julian

  ---
Thus spake the master programmer:
 	"When a program is being tested, it is too late to make design changes."
 		-- Geoffrey James, "The Tao of Programming"