threads / discuss / 20668

What's a good setup for submitting patches to the list properly?

Subject: What's a good setup for submitting patches to the list properly?

## tl;dr

10 messages between Aug 20, 2009 and Aug 25, 2009.

replies: 9people: 4as markdown or json

Thell Fowler· Aug 20, 2009, 00:09 UTC · lore

Sorry for once again.

I haven't been able to figure out a good setup for posting patches to the list correctly, perhaps someone could tell me where I'm going wrong.

Alpine is setup to access git @ tbfowler.name with the 'postpone' folder being the 'Drafts' folder on the remote mail host, and a local mbox folder ~/mail/git

Locally I prepped the emails using:

git format-patch --cover-letter --full-index -n --in-reply-to=1249428804.2774.52.camel@GWPortableVCS --thread --signoff -6 --stdout>>~/mail/git

http://article.gmane.org/gmane.comp.version-control.git/124834

Thinking that the cover letter would be in reply to a previous thread, and that the rest would show as a reply to that. After doing the format-patch, I went into Alpine's git folder selected the messages and saved them to the Drafts folder, then did 'compose' for each one, filling in the information I thought was needed.

At that point, the msg list looked flat, so I opened Evolution Mail and looked at them there, they cascaded properly, so I sent them. Yet, now, looking on gmane each of the patch msgs is a top level post and the cover letter correctly posted as a reply to the previous thread.

What could I have done/checked before sending to make sure that these would have posted properly?

-- 
Thell

Thell Fowler· Aug 22, 2009, 15:01 UTC · re: Thell Fowler · lore

Re: What's a good setup for submitting patches to the list properly?

Thell Fowler (git@tbfowler.name) wrote on Aug 19, 2009:

Show 13 quoted lines

> I haven't been able to figure out a good setup for posting patches to the 
> list correctly, perhaps someone could tell me where I'm going wrong.
> 
> Alpine is setup to access git @ tbfowler.name with the 'postpone' folder 
> being the 'Drafts' folder on the remote mail host, and a local mbox folder 
> ~/mail/git
> 
> Locally I prepped the emails using:
> 
> git format-patch --cover-letter --full-index -n 
> --in-reply-to=1249428804.2774.52.camel@GWPortableVCS --thread --signoff -6 
> --stdout>>~/mail/git
>

Did I miss something with that command?

Show 8 quoted lines

> http://article.gmane.org/gmane.comp.version-control.git/124834
> 
> Thinking that the cover letter would be in reply to a previous thread, and 
> that the rest would show as a reply to that.  After doing the 
> format-patch, I went into Alpine's git folder selected the messages and 
> saved them to the Drafts folder, then did 'compose' for each one, filling 
> in the information I thought was needed.
>

Perhaps the saving to a new folder could've messed something up with the headers?

[snip]

> What could I have done/checked before sending to make sure that these 
> would have posted properly?

No input on this? Perhaps I should've posted to the git user or alpine lists?

Either way, I'll be sending a new version of the patch I've been working on and rather than have them show as top posts again I'd rather do it correctly.

Or perhaps there is an easier more direct route...

-- 
Thell

Christian Couder· Aug 22, 2009, 20:20 UTC · re: Thell Fowler · lore

Re: What's a good setup for submitting patches to the list properly?

On Saturday 22 August 2009, Thell Fowler wrote:

>
> > What could I have done/checked before sending to make sure that these
> > would have posted properly?

Perhaps you could send them to yourself.

> No input on this?  Perhaps I should've posted to the git user or alpine
> lists?

It's ok to post this kind of questions on the git mailing list.

There is "git send-email" that is bundled with git. But I use git-mail-commits from Julian Philips. I am very happy with it. Thanks Julian!

Regards, Christian.

Nicolas Sebrecht· Aug 22, 2009, 20:56 UTC · re: Christian Couder · lore

git-mail-commits (Re: What's a good setup for submitting patches to the list properly?)

The 22/08/09, Christian Couder wrote:

> There is "git send-email" that is bundled with git. But I use 
> git-mail-commits from Julian Philips. I am very happy with it. Thanks 
> Julian!

Isn't there any public repo for it?

-- 
Nicolas Sebrecht

Christian Couder· Aug 23, 2009, 07:11 UTC · re: Nicolas Sebrecht · lore

Re: git-mail-commits (Re: What's a good setup for submitting patches to the list properly?)

On Saturday 22 August 2009, Nicolas Sebrecht wrote:

Show 6 quoted lines

> The 22/08/09, Christian Couder wrote:
> > There is "git send-email" that is bundled with git. But I use
> > git-mail-commits from Julian Philips. I am very happy with it. Thanks
> > Julian!
>
> Isn't there any public repo for it?

Not that I know of, but I think it would be a good idea to publish it (perhaps in contrib/).

Julian?

Regards, Christian.

Julian Phillips· Aug 23, 2009, 23:05 UTC · re: Christian Couder · lore

Re: git-mail-commits (Re: What's a good setup for submitting patches to the list properly?)

On Sun, 23 Aug 2009, Christian Couder wrote:

Show 12 quoted lines

> On Saturday 22 August 2009, Nicolas Sebrecht wrote:
>> The 22/08/09, Christian Couder wrote:
>>> There is "git send-email" that is bundled with git. But I use
>>> git-mail-commits from Julian Philips. I am very happy with it. Thanks
>>> Julian!
>>
>> Isn't there any public repo for it?
>
> Not that I know of, but I think it would be a good idea to publish it
> (perhaps in contrib/).
>
> Julian?

Using the awsome power of git I have managed to extract it from my random tools private repo to here as if I had written it to be a separate entity from the start:

git://git.q42.co.uk/mail_commits.git (gitweb: http://git.q42.co.uk/w/mail_commits.git)

If it would be considered useful, then I can also create a patch to add it to contrib (there is a master branch in the above repo where I have subtree merged it in already - though that was more to experiment with doing subtree merging)

-- 
Julian

  ---
The means-and-ends moralists, or non-doers, always end up on their ends
without any means.
 		-- Saul Alinsky

Nicolas Sebrecht· Aug 23, 2009, 23:41 UTC · re: Julian Phillips · lore

Re: git-mail-commits (Re:What's a good setup for submitting patches to the list properly?)

The 24/08/09, Julian Phillips wrote:

Show 8 quoted lines

> On Sun, 23 Aug 2009, Christian Couder wrote:
>
> Using the awsome power of git I have managed to extract it from my random 
> tools private repo to here as if I had written it to be a separate entity 
> from the start:
>
> git://git.q42.co.uk/mail_commits.git
> (gitweb: http://git.q42.co.uk/w/mail_commits.git)

Thanks a lot.

> If it would be considered useful, then I can also create a patch to add 
> it to contrib

I think it worth. That said, I would first add some config options like mail-commits.cc (not reviewed that much yet) to be a bit more consistent with the send-email program. I would also add README and INSTALL files.

Could you please consider to place your code under GPLv2?

-- 
Nicolas Sebrecht

Julian Phillips· Aug 25, 2009, 00:06 UTC · re: Nicolas Sebrecht · lore

Re: git-mail-commits (Re:What's a good setup for submitting patches to the list properly?)

On Mon, 24 Aug 2009, Nicolas Sebrecht wrote:

Show 18 quoted lines

> The 24/08/09, Julian Phillips wrote:
>> On Sun, 23 Aug 2009, Christian Couder wrote:
>>
>> Using the awsome power of git I have managed to extract it from my random
>> tools private repo to here as if I had written it to be a separate entity
>> from the start:
>>
>> git://git.q42.co.uk/mail_commits.git
>> (gitweb: http://git.q42.co.uk/w/mail_commits.git)
>
> Thanks a lot.
>
>> If it would be considered useful, then I can also create a patch to add
>> it to contrib
>
> I think it worth. That said, I would first add some config options like
> mail-commits.cc (not reviewed that much yet) to be a bit more consistent
> with the send-email program. I would also add README and INSTALL files.

Yeah ... it would be nice to have more options settable via config. Some form of documentation would also be a good idea, and I would like to tidy the code up a bit. Kinda sort on tuits just at the moment though ... :(

> Could you please consider to place your code under GPLv2?

I have added a license statement.

-- 
Julian

  ---
Thus spake the master programmer:
 	"When a program is being tested, it is too late to make design changes."
 		-- Geoffrey James, "The Tao of Programming"

Nicolas Sebrecht· Aug 25, 2009, 00:14 UTC · re: Julian Phillips · lore

Re: git-mail-commits (Re:What's a good setup for submitting patches to the list properly?)

The 25/08/09, Julian Phillips wrote:

Show 9 quoted lines

> On Mon, 24 Aug 2009, Nicolas Sebrecht wrote:
>
> > I think it worth. That said, I would first add some config options like
> > mail-commits.cc (not reviewed that much yet) to be a bit more consistent
> > with the send-email program. I would also add README and INSTALL files.
>
> Yeah ... it would be nice to have more options settable via config.  Some 
> form of documentation would also be a good idea, and I would like to tidy 
> the code up a bit.  Kinda sort on tuits just at the moment though ... :(

Will have help from me. I find it nice to have a python alternative to send-email. ,-p

> > Could you please consider to place your code under GPLv2?
>
> I have added a license statement.

Thank you. Patches comming.

-- 
Nicolas Sebrecht

Thell Fowler· Aug 22, 2009, 20:58 UTC · re: Christian Couder · lore

Re: What's a good setup for submitting patches to the list properly?

Christian Couder (chriscool@tuxfamily.org) wrote on Aug 22, 2009:

Show 7 quoted lines

> On Saturday 22 August 2009, Thell Fowler wrote:
> >
> > > What could I have done/checked before sending to make sure that these
> > > would have posted properly?
> 
> Perhaps you could send them to yourself.
>

Yes, I did. They all showed up under the correct thread, but then I changed how I did it by adding cover-letter to the format-patch options.

BTW - After looking at the headers it looks like the cover letter header worked just fine, but that the cover letter msg-id changed between when format-patch created it and when it was sent out causing the reset of the msgs to not have anything to reference to.

Show 9 quoted lines

> > No input on this?  Perhaps I should've posted to the git user or alpine
> > lists?
> 
> It's ok to post this kind of questions on the git mailing list.
> 
> There is "git send-email" that is bundled with git. But I use 
> git-mail-commits from Julian Philips. I am very happy with it. Thanks 
> Julian!
>

I guess I'll setup smtp and try the send-email route, not sure if that is going to change anything having to do with the In-Reply-To field and a cover letter or how it shows in the threading.

If that doesn't work then I'll give Julian's mail-commits a whirl.

Thanks for replying Christian!

-- 
Thell