Re: [PATCH 2/3 v3] Use an external program to implement fetching with curl

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Aug 5, 2009, 15:45 UTC
Message-ID: <alpine.LNX.2.00.0908051135080.2147@iabervon.org>
In-Reply-To: <alpine.DEB.1.00.0908051203550.8306@pacific.mpi-cbg.de>

On Wed, 5 Aug 2009, Johannes Schindelin wrote:

Show 20 quoted lines

> Hi,
> 
> On Fri, 31 Jul 2009, Daniel Barkalow wrote:
> 
> > Use the transport native helper mechanism to fetch by http (and ftp, etc).
> > 
> > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> > ---
> > Note that the bulk of remote-curl is code moved verbatim from transport.c; 
> > cleaning it up is a separate topic.
> > 
> >  Makefile      |    5 ++
> >  remote-curl.c |  139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  transport.c   |  136 +-------------------------------------------------------
> >  3 files changed, 145 insertions(+), 135 deletions(-)
> >  create mode 100644 remote-curl.c
> 
> I wanted to suggest using the -C option so that the patch would consist of 
> mostly deleted lines (easier to verify then that it was a code move), but 
> transport.c is over 1000 lines, so that would not have worked!

Yeah; I did use -C (so patch 3 was an obvious move), but git was wiser than to produce a copy-and-delete-85% version anyway. Someday, I want to have a diff output format that makes these things clear somehow. I think it would be not-too-hard to get the diff code to determine that an addition matches or almost matches a deletion (or some unchanged code), and provide library access to this information, but representing it to humans (and getting patch to still work) is hard.

	-Daniel
*This .sig left intentionally blank*