Re: [PATCH 2/3 v3] Use an external program to implement fetching with curl

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 5, 2009, 10:05 UTC
Message-ID: <alpine.DEB.1.00.0908051203550.8306@pacific.mpi-cbg.de>
In-Reply-To: <alpine.LNX.2.00.0907310112400.2147@iabervon.org>

Hi,

On Fri, 31 Jul 2009, Daniel Barkalow wrote:

Show 12 quoted lines

> Use the transport native helper mechanism to fetch by http (and ftp, etc).
> 
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> ---
> Note that the bulk of remote-curl is code moved verbatim from transport.c; 
> cleaning it up is a separate topic.
> 
>  Makefile      |    5 ++
>  remote-curl.c |  139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  transport.c   |  136 +-------------------------------------------------------
>  3 files changed, 145 insertions(+), 135 deletions(-)
>  create mode 100644 remote-curl.c

I wanted to suggest using the -C option so that the patch would consist of mostly deleted lines (easier to verify then that it was a code move), but transport.c is over 1000 lines, so that would not have worked!

So I do like the patch, and you're obviously correct about the clean up.

Ciao, Dscho