Re: [PATCH 1/3] Add support for external programs for handling native fetches

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jul 25, 2009, 19:09 UTC
Message-ID: <alpine.LNX.2.00.0907251446460.2147@iabervon.org>
In-Reply-To: <20090725184526.GB11191@spearce.org>

On Sat, 25 Jul 2009, Shawn O. Pearce wrote:

Show 12 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> wrote:
> > +Commands are given by the caller on the helper's standard input, one per line.
> > +
> > +'list'::
> > +	Outputs the names of refs followed by the hex of their values
> > +	or "@<name>" for symrefs, one per line. After the complete
> > +	list, outputs a blank line.
> 
> I hate to be a nit, but why this format and not the one that is
> produced by `git ls-remote` and the native protocol?  I know its
> pretty arbitrary either way, but since we already have a history
> of using "SHA1 ref\n" why not continue that tradition here?

In the VCS protocol, the SHA1 is generally not known when simply listing refs, so I didn't have a useless initial field in that protocol; I just inherited having the line start with the name for this protocol.

In any case, I want to be able to support symrefs, so an extension to the tradition is required, but putting @<dest> before the name instead of after is easy enough.

	-Daniel
*This .sig left intentionally blank*