Re: [PATCH 1/3] Add support for external programs for handling native fetches

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jul 25, 2009, 18:25 UTC
Message-ID: <alpine.LFD.2.01.0907251107500.3960@localhost.localdomain>
In-Reply-To: <alpine.LNX.2.00.0907251330240.2147@iabervon.org>

On Sat, 25 Jul 2009, Daniel Barkalow wrote:

Show 6 quoted lines

>
> This is similar to, but different from, my git-vcs-* stuff; this one 
> expects the helper to be able to look up sha1s for refs efficiently, and 
> to be able to fetch objects directly into the local object database 
> without fast-import. On the otherhand, it should be sufficiently general 
> to allow arbitrary methods for moving the data around.

Wonderful.

I tested the series, and now there is (not surprisingly, but I made sure to test anyway) no difference what-so-ever between NO_CURL and default, and 'ldd' looks nice.

Plus it looks like that whole "shim" thing is a good idea in general, in that it allows a much more flexible model for fetching/pushing.

So a very big Acked-by: from me for the series. I didn't test that http: works with it, but I don't personally even care, so I'd ack it even without that ;)

Btw, some real timing numbers for 'time make -j64 test':

 - before:
	real	1m16.070s
	user	2m47.046s
	sys	2m34.698s

 - after:
	real	0m58.851s
	user	1m57.087s
	sys	1m44.671s

so that's actually a real-world example of the whole 'scripting performance'. Not an insignificant speedup on my machine (with an obligatory "nyaah, nyaah, I can do the git test-suite under a minute" just to rub peoples noses in the fact that my desktop computer is disgustingly fast).

That's an almost 30% performance improvement, despite the fact that parts of the test suite didn't actually change (shell costs are the same, the svn tests are quite perl-intensive etc).

			Linus