Re: [PATCH] Quote LF in urls git fetch saves in FETCH_HEAD
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- May 13, 2009, 15:18 UTC
- Message-ID
- <alpine.LNX.2.00.0905131109240.2147@iabervon.org>
- In-Reply-To
- <81b0412b0905122306w4ed41bdiab073a05587fab55@mail.gmail.com>
On Wed, 13 May 2009, Alex Riesen wrote:
Show 23 quoted lines
> 2009/5/13 Junio C Hamano <gitster@pobox.com>:
> > Alex Riesen <raa.lkml@gmail.com> writes:
> >
> >> + for (i = 0; i < url_len; ++i)
> >> + if ('\n' == url[i])
> >> + fputs("\\n", fp);
> >> + else
> >> + fputc(url[i], fp);
> >> + fputc('\n', fp);
> >
> > This ad-hoc quoting feels _very_ wrong. Who is on the reading side and
> > how does it unquote?
>
> git fmt-merge-msg. It does not unquote. The url is purely informational here.
> OTOH, the \n shouldn't be in url text at all, so treat it as slightly
> less annoying
> warning.
>
> > If it is just informational use only, then it might make more sense to
> > drop this ugly "quoted \n" silently. I dunno.
>
> That'd mean to loose the information completely. Which is just as bad
> as putting the LF in the url in the first place.Looking back at the original message, it looks like the user included a newline in an argument to clone, and the fetch must have stripped it out (or ignored it in some other fashion), because data was retrieved from a repository that doesn't have a newline in its name. Most likely, the newline should just be prohibited in the URL in the config file in the first place, and we shouldn't be able to get to the point of writing a FETCH_HEAD with that value.
-Daniel *This .sig left intentionally blank*