git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Improve the naming of guessed target repository for git clone

From
Junio C Hamano <gitster@pobox.com>
Date
May 14, 2009, 06:35 UTC
Message-ID
<7v8wl0xkcu.fsf@alter.siamese.dyndns.org>
In-Reply-To
<81b0412b0905132254n5046666t24f3887f1fd4e4d9@mail.gmail.com>
Alex Riesen <raa.lkml@gmail.com> writes:
Show 5 quoted lines
>> What's the point of this change, now that you have a fix in 1/2?  Who are
>> you helping with this patch?
>
> Without this the _automatically_ generated names for cloned repositories
> have all the whitespace around them.

Even if it has whitespace around its name, that's what you got from the upstream (a valid source of clone), and wasn't it you who said something about UNIX tradition of allowing LF and others in the filename?

If clone reports "ok we created this new repository" so that the caller can capture it, then the whole process should be able to cope with automatically generated names with or without the patch, shouldn't it?

Or are you trying to help a human user who gives a pathname ridden with excess whitespaces to "git clone", and that pathname _happens_ to work as a valid clone source, creating a new repository whose name is ridden with excess whitespaces the same way as the input pathname? After all, the user deliberately gave them to us, and the repository we cloned from had these excesses in its name (iow, without the excess whitespaces the clone itself wouldn't have worked). In such a case, is it really helping him to remove these whitespaces as excesses?

I do not understand the point of this patch and that is why I asked who you are trying to help.

Previous: Alex RiesenNext: Alex Riesen
Message 23 of 30 in “git fails with control characters in trunk directory name”
  1. Hugo MildenbergerMay 11, 2009
  2. Alex RiesenMay 12, 2009
  3. Hugo MildenbergerMay 12, 2009
  4. Alex RiesenMay 12, 2009
  5. Hugo MildenbergerMay 12, 2009
  6. Alex RiesenMay 12, 2009
  7. Hugo MildenbergerMay 12, 2009
  8. Alex RiesenMay 12, 2009
  9. Quote LF in urls git fetch saves in FETCH_HEADAlex Riesen, May 12, 2009
  10. Junio C HamanoMay 12, 2009
  11. Alex RiesenMay 13, 2009
  12. Hugo MildenbergerMay 13, 2009
  13. Daniel BarkalowMay 13, 2009
  14. Alex RiesenMay 13, 2009
  15. Alex RiesenMay 13, 2009
  16. Daniel BarkalowMay 13, 2009
  17. Alex RiesenMay 13, 2009
  18. Junio C HamanoMay 13, 2009
  19. 1/2 Quote LF in urls git fetch saves in FETCH_HEADAlex Riesen, May 13, 2009
  20. 2/2 Improve the naming of guessed target repository for git cloneAlex Riesen, May 13, 2009
  21. Junio C HamanoMay 14, 2009
  22. Alex RiesenMay 14, 2009
  23. Junio C HamanoMay 14, 2009
  24. Alex RiesenMay 14, 2009
  25. Hugo MildenbergerMay 14, 2009
  26. Alex RiesenMay 14, 2009
  27. Junio C HamanoMay 16, 2009
  28. Alex RiesenMay 12, 2009
  29. Alex RiesenMay 13, 2009
  30. Hugo MildenbergerMay 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.