Re: [RFC PATCH 4/3] Add example git-vcs-p4
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Jan 12, 2009, 18:36 UTC
- Message-ID
- <alpine.LNX.1.00.0901121325080.19665@iabervon.org>
- In-Reply-To
- <81b0412b0901120346x79772846p6e5097028fc9720c@mail.gmail.com>
On Mon, 12 Jan 2009, Alex Riesen wrote:
Show 12 quoted lines
> 2009/1/11 Daniel Barkalow <barkalow@iabervon.org>: > > diff --git a/Makefile b/Makefile > > > > +LIB_OBJS += p4client.o > > +LIB_OBJS += vcs-p4.o > > + > > > > +extern int cmd_p4(int argc, const char **argv, const char *prefix); > > + > > Why is your foreign VCS importer built-in? The majority wont ever need it, > yet they have to pay the price for its text being in git executable.
Purely for convenience in the RFC version. The real one will probably need to be linked separately, since it will want to have the option of using the terrible C++ API to the closed-source-but-you-can-download-it-from-them library.
-Daniel *This .sig left intentionally blank*