Re: [RFC PATCH 4/3] Add example git-vcs-p4

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2009, 06:29 UTC
Message-ID: <7viqoljaub.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0901120026290.19665@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

Show 5 quoted lines

>> vcs-p4.c:504: warning: ISO C90 forbids mixed declarations and code
>> make: *** [vcs-p4.o] Error 1
>
> I haven't been over the 4/3 stuff for coding style yet. But how do you get 
> these warnings?

I thought I have mentioned this already, but...

I compile with (at least) these:

    -Wno-pointer-to-int-cast
    -Wold-style-definition
    -Wdeclaration-after-statement

explicitly specified.

I also run kernel's checkpatch.pl script (but ignoring "more than 80-col is too long" rule) from time to time.

I consider these are good ways to check style-discipline.