Re: [RFC PATCH 1/3] Add "vcs" config option in remotes

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jan 12, 2009, 17:25 UTC
Message-ID: <alpine.LNX.1.00.0901121225330.19665@iabervon.org>
In-Reply-To: <36ca99e90901120152t7756e6d4n19521cbb7336c5fb@mail.gmail.com>

On Mon, 12 Jan 2009, Bert Wesarg wrote:

Show 16 quoted lines

> On Sun, Jan 11, 2009 at 21:12, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > diff --git a/builtin-push.c b/builtin-push.c
> > index 122fdcf..3fdedba 100644
> > --- a/builtin-push.c
> > +++ b/builtin-push.c
> > @@ -53,6 +53,9 @@ static int do_push(const char *repo, int flags)
> >        int i, errs;
> >        struct remote *remote = remote_get(repo);
> >
> > +       if (remote->foreign_vcs)
> > +               die("Pushing with foreign VCSes not supported.");
> > +
> >        if (!remote)
> >                die("bad repository '%s'", repo);
> >
> Use of remote before NULL check.

Good catch, thanks.

	-Daniel
*This .sig left intentionally blank*