Re: [RFC PATCH 1/3] Add "vcs" config option in remotes

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Jan 12, 2009, 09:52 UTC
Message-ID: <36ca99e90901120152t7756e6d4n19521cbb7336c5fb@mail.gmail.com>
In-Reply-To: <alpine.LNX.1.00.0901110332580.19665@iabervon.org>

On Sun, Jan 11, 2009 at 21:12, Daniel Barkalow <barkalow@iabervon.org> wrote:

Show 14 quoted lines

> diff --git a/builtin-push.c b/builtin-push.c
> index 122fdcf..3fdedba 100644
> --- a/builtin-push.c
> +++ b/builtin-push.c
> @@ -53,6 +53,9 @@ static int do_push(const char *repo, int flags)
>        int i, errs;
>        struct remote *remote = remote_get(repo);
>
> +       if (remote->foreign_vcs)
> +               die("Pushing with foreign VCSes not supported.");
> +
>        if (!remote)
>                die("bad repository '%s'", repo);
>

Use of remote before NULL check.

Bert