Re: git-clone --quiet broken?
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Jul 7, 2008, 01:40 UTC
- Message-ID
- <alpine.LNX.1.00.0807062131100.19665@iabervon.org>
- In-Reply-To
- <20080706225649.GD17659@steel.home>
On Mon, 7 Jul 2008, Alex Riesen wrote:
Show 21 quoted lines
> While at it, could we please have the first "Initialize" message
> removed?
>
> Initialize git/.git
> Initialized empty Git repository in /home/davej/git-trees/git/.git/
>
> The default output looks redundant (that of init_db too, but the full
> path can be useful sometimes). Something like this, perhaps:
>
> diff --git a/builtin-clone.c b/builtin-clone.c
> index 643c7d4..4a0f1ab 100644
> --- a/builtin-clone.c
> +++ b/builtin-clone.c
> @@ -421,7 +421,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
> die("could not create leading directories of '%s'", git_dir);
> set_git_dir(make_absolute_path(git_dir));
>
> - fprintf(stderr, "Initialize %s\n", git_dir);
> init_db(option_template, option_quiet ? INIT_DB_QUIET : 0);
>
> /*Yeah, that's clearly left-over debugging, and I think that's the only one left from this conversion, anyway.
Acked-by: Daniel Barkalow <barkalow@iabervon.org>