Re: git-clone --quiet broken?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 6, 2008, 00:56 UTC
- Message-ID
- <7vmykvrfta.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080705211616.GA3874@codemonkey.org.uk>
Dave Jones <davej@codemonkey.org.uk> writes:
Show 6 quoted lines
> The server I run various git snapshots on recently got upgraded to git 1.5.6, > ... > I could run the clone with 2>/dev/null, but I'd really like to get > mail when something breaks instead of it being totally silent. > > I'm assuming this was an unintentional side-effect of some other recent change?
Yeah, I would assume so, too ;-)
Daniel, is this enough? From re-reading the scripted version of git-clone, it appears that we *might* need to squelch no-progress if the stdout is not tty; I do not offhand if you got that right when you rewrote this in C.
transport.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/transport.c b/transport.c index 3ff8519..b2f0d8a 100644 --- a/transport.c +++ b/transport.c @@ -645,7 +645,8 @@ static int fetch_refs_via_pack(struct transport *transport, args.lock_pack = 1; args.use_thin_pack = data->thin; args.include_tag = data->followtags; - args.verbose = transport->verbose > 0; + args.verbose = (transport->verbose > 0); + args.quiet = (transport->verbose < 0); args.depth = data->depth; for (i = 0; i < nr_heads; i++)