git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] git-pack-objects: Automatically pack annotated tags if object was packed

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Mar 4, 2008, 02:49 UTC
Message-ID
<alpine.LNX.1.00.0803032145480.19665@iabervon.org>
In-Reply-To
<20080304023607.GA16152@spearce.org>
On Mon, 3 Mar 2008, Shawn O. Pearce wrote:
> +	if (auto_tags && nr_result)
> +		for_each_ref(add_ref_tag, NULL);

There's for_each_tag_ref() that does the path-based filter internally, in a possibly more efficient way, and avoids open-coding the test for whether this is a tag sort of ref.

Aside from that, it looks good to me.
	-Daniel
*This .sig left intentionally blank*
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 6 of 8 in “git-pack-objects: Automatically pack annotated tags if object was packed”
  1. 1/3 git-pack-objects: Automatically pack annotated tags if object was packedShawn O. Pearce, Mar 4, 2008
  2. Nicolas PitreMar 4, 2008
  3. Shawn O. PearceMar 4, 2008
  4. Johannes SixtMar 4, 2008
  5. Shawn O. PearceMar 5, 2008
  6. Daniel BarkalowMar 4, 2008
  7. Shawn O. PearceMar 4, 2008
  8. Daniel BarkalowMar 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.