From: Daniel Barkalow <barkalow@iabervon.org>
Date: Tue, 04 Mar 2008 02:49:12 GMT
Subject: Re: [PATCH 1/3] git-pack-objects: Automatically pack annotated tags if object was packed
Message-ID: <alpine.LNX.1.00.0803032145480.19665@iabervon.org>
In-Reply-To: <20080304023607.GA16152@spearce.org>

On Mon, 3 Mar 2008, Shawn O. Pearce wrote:

> +	if (auto_tags && nr_result)
> +		for_each_ref(add_ref_tag, NULL);

There's for_each_tag_ref() that does the path-based filter internally, in 
a possibly more efficient way, and avoids open-coding the test for whether 
this is a tag sort of ref.

Aside from that, it looks good to me.

	-Daniel
*This .sig left intentionally blank*