git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] Export some email and pretty-printing functions

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Feb 19, 2008, 16:19 UTC
Message-ID
<alpine.LNX.1.00.0802191117540.19024@iabervon.org>
In-Reply-To
<alpine.LSU.1.00.0802191305160.30505@racer.site>
On Tue, 19 Feb 2008, Johannes Schindelin wrote:
Show 10 quoted lines
> Hi,
> 
> On Mon, 18 Feb 2008, Daniel Barkalow wrote:
> 
> > These will be used for generating the cover letter in addition to the 
> > patch emails.
> 
> I copied the hunks of log_write_email_headers() and used "git diff -w" to 
> verify that only one thing changed: "sha1" was renamed to "name".  It 
> might make sense to rename it to "from", but then, I do not really care.

No, it's actually supposed to be the filename, I think. Beats me as to why it's used as the envelope from, but I'm not changing the logic there.

	-Daniel
*This .sig left intentionally blank*
Previous: Johannes SchindelinNext: Daniel Barkalow
Message 8 of 12 in “Add more tests for format-patch”
  1. 1/5 Add more tests for format-patchDaniel Barkalow, Feb 19, 2008
  2. 2/5 Improve message-id generation flow control for format-patchDaniel Barkalow, Feb 19, 2008
  3. Johannes SchindelinFeb 19, 2008
  4. Daniel BarkalowFeb 19, 2008
  5. Johannes SchindelinFeb 19, 2008
  6. 3/5 Export some email and pretty-printing functionsDaniel Barkalow, Feb 19, 2008
  7. Johannes SchindelinFeb 19, 2008
  8. Daniel BarkalowFeb 19, 2008
  9. 4/5 Retain extra blank lines between the summary and the bodyDaniel Barkalow, Feb 19, 2008
  10. 5/5 Add a --cover-letter option to format-patchDaniel Barkalow, Feb 19, 2008
  11. Junio C HamanoFeb 20, 2008
  12. Daniel BarkalowFeb 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.