Re: [PATCH 4/4] Add a --cover-letter option to format-patch

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 18, 2008, 21:17 UTC
Message-ID: <alpine.LNX.1.00.0802181616530.5816@iabervon.org>
In-Reply-To: <7vejbanf8l.fsf@gitster.siamese.dyndns.org>

On Mon, 18 Feb 2008, Junio C Hamano wrote:

Show 25 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> >> > diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> >> > index 651efe6..53e6d2e 100644
> >> > --- a/Documentation/git-format-patch.txt
> >> > +++ b/Documentation/git-format-patch.txt
> >> > @@ -17,6 +17,7 @@ SYNOPSIS
> >> >                     [--in-reply-to=Message-Id] [--suffix=.<sfx>]
> >> >                     [--ignore-if-in-upstream]
> >> >                     [--subject-prefix=Subject-Prefix]
> >> > +                   [--cover-letter]
> >> >  		   [ <since> | <revision range> ]
> >> 
> >> Since you are already there, and it is really a small change, why not fix 
> >> the whitespace?
> >
> > What *is* the correct whitespace for alignment in documentation?
> 
> The last time I checked, AsciiDoc output did not change before
> and after running "expand" and then "unexpand" in all *.txt
> files in Documentation/ directory, so if it is indenting to
> multiple of 8, HT is fine.
> 
> Don't we have Documentation/.gitattributes that says indentation
> to 8*N-th column must be done with N HTs these days?

Ah, yes, that's right; I'll fix that block.

	-Daniel
*This .sig left intentionally blank*