Re: [PATCH 4/4] Add a --cover-letter option to format-patch

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 18, 2008, 03:45 UTC
Message-ID: <7v4pc7udux.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0802171335520.5816@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

Show 7 quoted lines

> +	argv[0] = "shortlog";
> +	argv[1] = head_sha1;
> +	argv[2] = "--not";
> +	argv[3] = origin_sha1;
> +	argv[4] = NULL;
> +	fflush(stdout);
> +	run_command_v_opt(argv, RUN_GIT_CMD);

Please make it a habit to always append "--" disambiguator for such command lines generated internally. In this case you are not usinging short and common name like "master" or "HEAD" but 40-letter-long hex string, so it is much less likely to get hit by the "ambiguous rev vs file" rule, but even then it is still possible that a work tree happens to have a file with the same name.

Show 14 quoted lines

> @@ -0,0 +1,101 @@
> +$ git format-patch --stdout --cover-letter -n initial..master^
> +From 9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0 Mon Sep 17 00:00:00 2001
> +From: C O Mitter <committer@example.com>
> +Date: Mon, 26 Jun 2006 00:05:00 +0000
> +Subject: [DIFFERENT_PREFIX 0/2] *** SUBJECT HERE ***
> +
> +
> +*** BLURB HERE ***
> +
> +A U Thor (2):
> +      Second
> +      Third
> +

This probably falls within the "personal taste" category, but I'd rather not to see two extra blank lines between Subject: and BLURB HERE.