git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: http-push as a builtin ? (Was: Is there a reason to keep walker.c ?)

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Jan 28, 2008, 19:45 UTC
Message-ID
<alpine.LNX.1.00.0801281438450.13593@iabervon.org>
In-Reply-To
<20080128185828.GA14804@glandium.org>
On Mon, 28 Jan 2008, Mike Hommey wrote:
Show 23 quoted lines
> On Mon, Jan 28, 2008 at 08:17:49AM +0100, Mike Hommey wrote:
> > On Sun, Jan 27, 2008 at 04:23:17PM -0500, Daniel Barkalow wrote:
> > > On Sun, 27 Jan 2008, Mike Hommey wrote:
> > > 
> > > > Hi,
> > > > 
> > > > While working on the http code refactoring, I got to wonder if the
> > > > walker.c "wrapper", that is only used for the http transport, is still
> > > > worth keeping. If there are plans for others transport to use this code,
> > > > obviously, it would be worth keeping, but on the contrary, I think it
> > > > would simplify the http transport code even more. What do you think ?
> > > 
> > > It would be a good base for sftp (i.e. dumb file access over ssh). In 
> > > fact, I think stuff should ideally be moved into walker.c such that the 
> > > HTTP-specific code just handles access to files by filename and the logic 
> > > of what files to request in what order is in walker.c. I think this would 
> > > get the simplification you're looking for while making it easy to add sftp 
> > > or any other situation where you have only slow remote filesystem-like 
> > > access to the repository.
> > 
> > I like this idea. I'll probably implement that, then.
> 
> BTW, would there be objections to have http-push as a builtin ?

Not from me. Actually, it would be ideal to call its functions directly from transport.c and deprecate the separate command. (And possibly separate the control structure from the HTTP code and move the former into walker.c where it could be used by sftp)

	-Daniel
*This .sig left intentionally blank*
Previous: Mike Hommey
Message 8 of 8 in “Is there a reason to keep walker.c ?”
  1. Mike HommeyJan 27, 2008
  2. Johannes SchindelinJan 27, 2008
  3. Mike HommeyJan 27, 2008
  4. Jakub NarebskiJan 27, 2008
  5. Daniel BarkalowJan 27, 2008
  6. Mike HommeyJan 28, 2008
  7. http-push as a builtin ? (Was: Is there a reason to keep walker.c ?)Mike Hommey, Jan 28, 2008
  8. Daniel BarkalowJan 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.