git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Reduce the number of connects when fetching

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Jan 26, 2008, 21:37 UTC
Message-ID
<alpine.LNX.1.00.0801261635230.13593@iabervon.org>
In-Reply-To
<alpine.LSU.1.00.0801261734360.23907@racer.site>
On Sat, 26 Jan 2008, Johannes Schindelin wrote:
Show 14 quoted lines
> Hi,
> 
> On Fri, 25 Jan 2008, Daniel Barkalow wrote:
> 
> > This shares the connection between getting the remote ref list and 
> > getting objects in the first batch. (A second connection is still used 
> > to follow tags)
> 
> I applied this locally, and now I get a few "fatal: The remote end hung up 
> unexpectedly" errors; when I started "git fetch" in a gdb session, it did 
> not stop at die_builtin(), which leads me to believe that the error comes 
> from upload-pack.
> 
> Any ideas?

In fact, it seems to me that quickfetch short-circuits the fetch portion of the connection, and, if it takes care of everything (i.e., there's nothing to do), the connection gets dropped while the remote is still expecting communication. Essentially harmless but wrong, and I'll clean it up.

	-Daniel
*This .sig left intentionally blank*
Previous: Daniel Barkalow
Message 4 of 4 in “Reduce the number of connects when fetching”
  1. Reduce the number of connects when fetchingDaniel Barkalow, Jan 25, 2008
  2. Johannes SchindelinJan 26, 2008
  3. Daniel BarkalowJan 26, 2008
  4. Daniel BarkalowJan 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.