Re: [PATCH] Reduce the number of connects when fetching

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jan 26, 2008, 21:25 UTC
Message-ID: <alpine.LNX.1.00.0801261618470.13593@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0801261734360.23907@racer.site>

On Sat, 26 Jan 2008, Johannes Schindelin wrote:

Show 14 quoted lines

> Hi,
> 
> On Fri, 25 Jan 2008, Daniel Barkalow wrote:
> 
> > This shares the connection between getting the remote ref list and 
> > getting objects in the first batch. (A second connection is still used 
> > to follow tags)
> 
> I applied this locally, and now I get a few "fatal: The remote end hung up 
> unexpectedly" errors; when I started "git fetch" in a gdb session, it did 
> not stop at die_builtin(), which leads me to believe that the error comes 
> from upload-pack.
> 
> Any ideas?

That sounds vaguely like the symptom of one of the bug I had when I wrote it, but I think that was causing test failures and this isn't. In my testing, I've gotten it to happen, but only with ssh. What is your test case like?

I haven't gotten it to fail when it had anything to do, so I'm thinking it might be forgetting to let the remote end know that it isn't interested.

	-Daniel
*This .sig left intentionally blank*