git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

From
TGThomas Gleixner <tglx@linutronix.de>
Date
Oct 23, 2012, 21:25 UTC
Message-ID
<alpine.LFD.2.02.1210232307480.2756@ionos>
In-Reply-To
<20121023205119.GA27729@sigill.intra.peff.net>
On Tue, 23 Oct 2012, Jeff King wrote:
Show 15 quoted lines
> On Tue, Oct 23, 2012 at 10:47:28PM +0200, Thomas Gleixner wrote:
> 
> > I agree that this is a common issue. Acked-by/Reviewed-by mails come
> > in after the fact that the patch has been committed to an immutable
> > (i.e no-rebase mode) branch or if the change in question already hit
> > Linus tree.
> > 
> > Still it would be nice to have a recording of that in the git tree
> > itself.
> > 
> > Something like: "git --attach SHA1 <comment>" would be appreciated!
> 
> It is spelled:
> 
>   git notes add -m <comment> SHA1
Cool!
> The resulting notes are stored in a separate revision-controlled branch
Which branch(es) is/are that ? What are the semantics of that?
Assume I commit something to branch "foo"

Now I get that late Ack/Reviewed-by and want to associate that to that commit in branch "foo". Does that go into "notes/foo" ?

If yes, good. (Any other sensible prefix is good as well). If no, where does it go to?

Later when I send a pull request to my upstream maintainer for branch "foo" does he get "notes/foo" automagically or do I have to request to pull him that separately?

Either way is fine for me, though something which lets me "automate" that would be appreciated. I can work around that easily as my pull requests are generated via scripts, so I can add the secondary one for the dependent "notes" branch if necessary. Though it would be nice to avoid that. Avoiding that, i.e having a straight connection (maybe configurable) between "foo" and "notes/foo" and the commits which have not yet hit my upstream maintainer would make my life easier. I.e. I just have to check "foo" for stuff which is not upstream yet instead of checking both, but that might just be my laziness.

Thoughts?
	tglx
Previous: Catalin MarinasNext: Jeff King
Message 6 of 14 in “Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE”
  1. Thomas GleixnerOct 23, 2012
  2. Jeff KingOct 23, 2012
  3. Catalin MarinasOct 23, 2012
  4. Jeff KingOct 23, 2012
  5. Catalin MarinasOct 24, 2012
  6. Thomas GleixnerOct 23, 2012
  7. Jeff KingOct 23, 2012
  8. Marc GauthierOct 23, 2012
  9. Jeff KingOct 23, 2012
  10. Johannes SixtOct 24, 2012
  11. Linus TorvaldsOct 24, 2012
  12. Al ViroOct 24, 2012
  13. Linus TorvaldsOct 24, 2012
  14. Ingo MolnarOct 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.