Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

From: Thomas Gleixner <tglx@linutronix.de>
Date: Oct 23, 2012, 20:47 UTC
Message-ID: <alpine.LFD.2.02.1210232232070.2756@ionos>
In-Reply-To: <20121023184122.GZ2616@ZenIV.linux.org.uk>

On Tue, 23 Oct 2012, Al Viro wrote:

Show 15 quoted lines

> On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote:
> 
> > I fetched the series from your arch-tile branch and built it, and it works
> > fine.  It looks good from my inspection:
> > 
> > Acked-by: Chris Metcalf <cmetcalf@tilera.com>
> 
> Thanks; Acked-by applied, branch pushed and put into no-rebase mode.
> 
> BTW, something like detached Acked-by objects might be a good idea - i.e.
> commit-like git object with amendment to commit message of a given ancestor.
> The situation when ACKs come only after the commit has been pushed is quite
> common.  Linus, what do you think about usefulness of such thing?  Ability
> to append ACKed-by/Tested-by of an earlier commit to a branch instead of
> git commit --amend + possibly some cherry-picks + force-push, that is.

I agree that this is a common issue. Acked-by/Reviewed-by mails come in after the fact that the patch has been committed to an immutable (i.e no-rebase mode) branch or if the change in question already hit Linus tree.

Still it would be nice to have a recording of that in the git tree itself.

Something like: "git --attach SHA1 <comment>" would be appreciated!

Thanks,

	tglx