Re: [PATCH] Update "gc" behavior in commit, merge, am, rebase and index-pack
- From
Nicolas Pitre <nico@fluxnic.net>
- Date
- May 12, 2012, 17:36 UTC
- Message-ID
- <alpine.LFD.2.02.1205121326380.21030@xanadu.home>
- In-Reply-To
- <1336810134-3103-1-git-send-email-pclouds@gmail.com>
On Sat, 12 May 2012, Nguyễn Thái Ngọc Duy wrote:
Show 15 quoted lines
> A few attempts have been made in the past to change 'gc --auto' [1] > [2]. This is another such attempt. > > Commit d4bb43e (Invoke "git gc --auto" from commit, merge, am and > rebase. - 2007-09-05) used the rule to put "gc --auto" is "where > update-ref occurs". I would argue that this is not a good condition to > run gc, because (at least current) gc is slow. We encourage commit > often and rebase to make all patches in good shape and this workflow > should not be interrupted/slowed down by random "gc --auto". > > Instead, we could just inform users that "gc" should be run soon in > commonly used commands (this patch also reinstates "gc" check in > commit, which was lost at the sh->C conversion). [1] and [2] can annoy > users constantly with warnings. This patch shows the warning at most > once a day.
I agree with this. However don't bother making this once a day. There is no harm in warning every time. Referring to the man page as git --auto does when it actually meets its treshold wouldn't be a bad thing either as incidentally that would contain the info to get rid of the warning.
Nicolas