Re: [PATCH v2 1/5] Add convenient function to do automatic garbage collection
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- May 19, 2012, 04:56 UTC
- Message-ID
- <CACsJy8A-gaQFP_X+f4t_WaLG9Gn0b8e1YmH3gF4jmPhqW8m5xw@mail.gmail.com>
- In-Reply-To
- <xmqqvcjt15g5.fsf@junio.mtv.corp.google.com>
On Sat, May 19, 2012 at 5:37 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> This function also avoids forking most of the time by performing some
>> check in process.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ...
>> @@ -64,6 +66,10 @@ static int gc_config(const char *var, const char *value, void *cb)
>> }
>> return git_config_string(&prune_expire, var, value);
>> }
>> + if (cb && !strcmp(var, cb)) {
>> + auto_gc = git_config_bool(var, value);
>> + return 0;
>> + }
>
> This does not look like "add convenient function for auto-gc" nor "avoid
> forking"; it is something else that is not explained.It takes care of "foo.autogc" config key in commands that allows to suppress auto gc. But yes, commit message can use some improvement.
-- Duy