Re: Add '--bisect' revision machinery argument
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Oct 28, 2009, 23:32 UTC
- Message-ID
- <alpine.LFD.2.01.0910281631400.31845@localhost.localdomain>
- In-Reply-To
- <7viqdzgls9.fsf@alter.siamese.dyndns.org>
On Wed, 28 Oct 2009, Junio C Hamano wrote:
> > This shows a very nice direction to evolve, but your patch as-is breaks > "rev-list --bisect", I think.
I think you're right. I tested git rev-parse, and the 'git log' machinery, but I didn't think about the fact that we already had a meaning for '--bisect' in rev-list.
> Also, the helper of "git bisect" can and probably should be taught to just > ask this new behaviour from the revision machinery, instead of collecting > good and bad refs itself using bisect.c::read_bisect_refs().
Yeah. And git-bisect.sh can be simplified too.
Linus