Re: Add '--bisect' revision machinery argument
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Oct 31, 2009, 20:58 UTC
- Message-ID
- <200910312158.09049.chriscool@tuxfamily.org>
- In-Reply-To
- <alpine.LFD.2.01.0910281631400.31845@localhost.localdomain>
On Thursday 29 October 2009, Linus Torvalds wrote:
Show 14 quoted lines
> On Wed, 28 Oct 2009, Junio C Hamano wrote: > > This shows a very nice direction to evolve, but your patch as-is breaks > > "rev-list --bisect", I think. > > I think you're right. I tested git rev-parse, and the 'git log' > machinery, but I didn't think about the fact that we already had a > meaning > for '--bisect' in rev-list. > > > Also, the helper of "git bisect" can and probably should be taught to > > just ask this new behaviour from the revision machinery, instead of > > collecting good and bad refs itself using bisect.c::read_bisect_refs(). > > Yeah. And git-bisect.sh can be simplified too.
I will have a look at that.
Sorry for not responding earlier but I just came back today from the Linux Kongress 2009 in Dresden (http://www.linux-kongress.org/2009/).
Best regards, Christian.