Re: [PATCH] Revert "pack-objects: fix pack generation when using pack_size_limit"

From: Nicolas Pitre <nico@fluxnic.net>
Date: Feb 8, 2010, 18:11 UTC
Message-ID: <alpine.LFD.2.00.1002081306420.1681@xanadu.home>
In-Reply-To: <7v3a1bpqqq.fsf@alter.siamese.dyndns.org>

On Mon, 8 Feb 2010, Junio C Hamano wrote:

Show 19 quoted lines

> Nicolas Pitre <nico@fluxnic.net> writes:
> 
> > This reverts most of commit a2430dde8ceaaaabf05937438249397b883ca77a.
> >
> > That commit made the situation better for repositories with relatively
> > small number of objects.  However with many objects and a small pack size
> > limit, the time required to complete the repack tends towards O(n^2),
> > or even much worse with long delta chains.
> >
> > Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> > ---
> >
> > Fixing this doesn't appear to be as trivial as I initially thought.
> > Although I do have some ideas, they're not appropriate so late in 
> > the -rc period.
> 
> Ok, so the idea is what a2430dd tried is an issue worth addressing but the
> particular execution wasn't good?  We revert it for now, but we will try
> again after the release, perhaps doing it differently?

Exact. I did try a few things in the hope that the "fix" would have been trivial enough to merge now but none of that worked satisfactorily.

> I agree with it if that is your intention, but "Most of" bugs me a bit.

It's not a straight revert in the sense that I left in some cleanups and left out the redundant self consistency check. Only the significant parts were reverted.

Nicolas