Re: [PATCH] Revert "pack-objects: fix pack generation when using pack_size_limit"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2010, 17:43 UTC
Message-ID: <7v3a1bpqqq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.1002081032530.1681@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> writes:

Show 13 quoted lines

> This reverts most of commit a2430dde8ceaaaabf05937438249397b883ca77a.
>
> That commit made the situation better for repositories with relatively
> small number of objects.  However with many objects and a small pack size
> limit, the time required to complete the repack tends towards O(n^2),
> or even much worse with long delta chains.
>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> ---
>
> Fixing this doesn't appear to be as trivial as I initially thought.
> Although I do have some ideas, they're not appropriate so late in 
> the -rc period.

Ok, so the idea is what a2430dd tried is an issue worth addressing but the particular execution wasn't good? We revert it for now, but we will try again after the release, perhaps doing it differently?

I agree with it if that is your intention, but "Most of" bugs me a bit.