git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [WIP] Shift rev-list enumeration from upload-pack to pack-objects

From
Nicolas Pitre <nico@cam.org>
Date
Jun 8, 2009, 00:50 UTC
Message-ID
<alpine.LFD.2.00.0906072043400.3906@xanadu.home>
In-Reply-To
<c77435a80906071504u16a46e03w6dfde9a3e694a5ec@mail.gmail.com>
On Mon, 8 Jun 2009, Nick Edelen wrote:
> man I can sure be blind at times...  alright fixed the latter two
> comments.  I changed the test file because that particular test wanted
> upload-pack to fail through the revision walker, which it could only
> now do if shallow objects were involved.

OK. However, since now we have 2 different paths for creating object list instead of only one (the existing one in upload-pack and the one in pack-objects), I'd prefer if you could add another test case to make sure the pack-objects path also fails appropriately.

The rest looks fine to me, and with the test issue fixed you could add my:

  Acked-by: Nicolas Pitre <nico@cam.org

to your next submission. Oh and you might change the subject prefix to [PATCH] as well since I think this won't be WIP anymore.

Nicolas
Previous: Nick EdelenNext: Junio C Hamano
Message 14 of 15 in “[WIP] Shift rev-list enumeration from upload-pack to pack-objects”
  1. sam@vilain.netJun 5, 2009
  2. Sam VilainJun 5, 2009
  3. Johannes SixtJun 5, 2009
  4. fetch-pack: close output channel after sideband demultiplexer terminatesJohannes Sixt, Jun 8, 2009
  5. Nicolas PitreJun 5, 2009
  6. Nick EdelenJun 7, 2009
  7. Nick EdelenJun 7, 2009
  8. Nicolas PitreJun 7, 2009
  9. Nick EdelenJun 7, 2009
  10. Nick EdelenJun 7, 2009
  11. Sam VilainJun 7, 2009
  12. Nicolas PitreJun 7, 2009
  13. Nick EdelenJun 7, 2009
  14. Nicolas PitreJun 8, 2009
  15. Junio C HamanoJun 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.