Re: [PATCH] gc --aggressive: make it really aggressive

From: Nicolas Pitre <nico@cam.org>
Date: Mar 18, 2009, 18:02 UTC
Message-ID: <alpine.LFD.2.00.0903181401000.30483@xanadu.home>
In-Reply-To: <alpine.DEB.1.00.0903181657180.10279@pacific.mpi-cbg.de>

On Wed, 18 Mar 2009, Johannes Schindelin wrote:

Show 20 quoted lines

> Hi,
> 
> On Thu, 6 Dec 2007, Johannes Schindelin wrote:
> 
> > 
> > The default was not to change the window or depth at all.  As suggested
> > by Jon Smirl, Linus Torvalds and others, default to
> > 
> > 	--window=250 --depth=250
> > 
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> 
> Guess what.  This is still unresolved, and yet somebody else had to be 
> bitten by 'git gc --aggressive' being everything but aggressive.
> 
> So...  I think it is high time to resolve the issue, either by applying 
> this patch with a delay of over one year, or by the pack wizards trying to 
> implement that 'never fall back to a worse delta' idea mentioned in this 
> thread.

This is just a bit complicated to implement (cycle avoidance, etc).

> Although I suggest, really, that implying --depth=250 --window=250 (unless 
> overridden by the config) with --aggressive is not at all wrong.

ACK.

Nicolas