Re: [PATCH] gc --aggressive: make it really aggressive

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 6, 2007, 15:55 UTC
Message-ID: <Pine.LNX.4.64.0712061552550.27959@racer.site>
In-Reply-To: <20071206142254.GD5959@artemis.madism.org>

Hi,

On Thu, 6 Dec 2007, Pierre Habouzit wrote:

Show 15 quoted lines

> On Thu, Dec 06, 2007 at 12:03:38PM +0000, Johannes Schindelin wrote:
> > 
> > The default was not to change the window or depth at all.  As 
> > suggested by Jon Smirl, Linus Torvalds and others, default to
> > 
> > 	--window=250 --depth=250
> 
>   well, this will explode on many quite reasonnably sized systems. This 
> should also use a memory-limit that could be auto-guessed from the 
> system total physical memory (50% of the actual memory could be a good 
> idea e.g.).
> 
>   On very large repositories, using that on the e.g. linux kernel, swaps 
> like hell on a machine with 1Go of ram, and almost nothing running on it 
> (less than 200Mo of ram actually used)

Yes.

However, I think that --aggressive should be aggressive, and if you decide to run it on a machine which lacks the muscle to be aggressive, well, you should have known better.

The upside: if you run this on a strong machine and clone it to a weak machine, you'll still have the benefit of a small pack (and you should mark it as .keep, too, to keep the benefit...)

Ciao, Dscho