Re: [BUG] minor: wrong handling of GIT_AUTHOR_DATE
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Aug 17, 2008, 16:07 UTC
- Message-ID
- <alpine.LFD.1.10.0808170905540.3324@nehalem.linux-foundation.org>
- In-Reply-To
- <7vljyw9pok.fsf@gitster.siamese.dyndns.org>
On Sat, 16 Aug 2008, Junio C Hamano wrote:
> > Is this because we do not initialize tm fields to "unknown" in the > beginning? I admit I haven't bothered to look at this part of the code > for a looong time.
Indeed. The _exact_ date handling initializes the date to -1 (and the time to 0), but the approxidate thing defaults to "now" and then modifies that.
Which is why we'd need to have a separate flags field for "I have initialized this field".
Linus