Re: [BUG] minor: wrong handling of GIT_AUTHOR_DATE

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2008, 02:46 UTC
Message-ID: <7vr68obbpd.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.1.10.0808161613520.3324@nehalem.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 6 quoted lines

> Junio, your call. But this one gets the date right for strings that just 
> randomly have some big number in them, ie
>
> 	[torvalds@nehalem git]$ ./test-date "17:25:54 917476713 2008-06-04 -0700"
> 	17:25:54 917476713 2008-06-04 -0700 -> 1212625554 -0700 -> Wed Jun  4 17:25:54 2008
> 	17:25:54 917476713 2008-06-04 -0700 -> Wed Jun  4 17:25:54 2008

Being able to parse this is a very low priority.

You've taught people here and on the kernel list that the "date" can use any non-digit-non-word as a word separator, and "git log --since 2.days" is something you often do.

People who followed that advice would have gotten used to this already, e.g.

   $ git reflog delete master@{07.04.2005.15:15:00.-0700}

should not be broken.

I think your first hunk needs to distinguish between "very-long-precision posint" (in which case we ignore because it is likely to be nanoseconds fraction) and others.