git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Bugfix for AIX tmpfile creation

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Jun 23, 2008, 22:55 UTC
Message-ID
<alpine.LFD.1.10.0806231552510.2926@woody.linux-foundation.org>
In-Reply-To
<7vy74vg4zq.fsf@gitster.siamese.dyndns.org>
On Mon, 23 Jun 2008, Junio C Hamano wrote:
>
> Hmm, we have quite a few calls to mkstemp(), so adding the workaround to
> this specific call site does not scale well as a fix, I am afraid.

All other callers of mkstemp() always rewrite the _entire_ path and don't care about the result after failure (since it failed)

The new 'create_tmpfile()' usage was/is special in that it re-uses the path without recreating it all, just the final part.

So I think Patrick's patch is fine and sufficient. Maybe I missed some in my quick grep, but it does look ok, and the create_tmpfile() usage really was pretty special.

		Linus
Previous: Junio C HamanoNext: patrick.higgins@cexp.com
Message 3 of 6 in “Bugfix for AIX tmpfile creation”
  1. Bugfix for AIX tmpfile creationPatrick Higgins, Jun 23, 2008
  2. Junio C HamanoJun 23, 2008
  3. Linus TorvaldsJun 23, 2008
  4. patrick.higgins@cexp.comJun 23, 2008
  5. Junio C HamanoJun 23, 2008
  6. Junio C HamanoJun 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.