RE: [PATCH/RFC] Bugfix for AIX tmpfile creation
On Behalf Of Linus Torvalds
Show 21 quoted lines
> To: Junio C Hamano
>
> On Mon, 23 Jun 2008, Junio C Hamano wrote:
> >
> > Hmm, we have quite a few calls to mkstemp(), so adding the
> workaround to
> > this specific call site does not scale well as a fix, I am afraid.
>
> All other callers of mkstemp() always rewrite the _entire_
> path and don't
> care about the result after failure (since it failed)
>
> The new 'create_tmpfile()' usage was/is special in that it
> re-uses the
> path without recreating it all, just the final part.
>
> So I think Patrick's patch is fine and sufficient. Maybe I
> missed some in
> my quick grep, but it does look ok, and the create_tmpfile()
> usage really
> was pretty special.
This is the only problem I've seen with it so far on AIX. I was really surprised because I hadn't seen any problems with any of the release candidates and had been using them all as they came out so I got lazy and didn't test the final release, but one of my co-workers let me know that it is broken this morning. Even the most basic things like git-add stopped working, and applying this small patch fixed all test cases. The irony is of course that I wanted 1.5.6 for the improved AIX support and the final release is completely broken on AIX!