Re: [PATCH] config: correct and clarify core.*compression documentation

From: Nicolas Pitre <nico@cam.org>
Date: Nov 19, 2007, 16:43 UTC
Message-ID: <alpine.LFD.0.99999.0711191139240.19105@xanadu.home>
In-Reply-To: <20071119162307.GI6212@lavos.net>

On Mon, 19 Nov 2007, Brian Downing wrote:

Show 12 quoted lines

> On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:
> > > * Explain that the default of core.compression is -1, zlib default, and
> > >   add a quote from zlib.h explaining what that actually means.
> > 
> > No, this is wrong.  core.compression has no default.  It is meaningful 
> > only when an explicit value is configured.
> 
> Would you prefer this?
> 
>        If not set, packs will be compressed to the zlib default level,
>        which is "a default compromise between speed and compression
>        (currently equivalent to level 6)."

This is still rather incorrect. If you want to be thorough, you should say that this setting provides a global default for pack.compression and core.loosecompression when those settings are not set. Otherwise pack.compression and core.loosecompression have a default of their own when neither is set.

Nicolas