Re: [PATCH] config: correct and clarify core.*compression documentation

From: Brian Downing <bdowning@lavos.net>
Date: Nov 19, 2007, 16:23 UTC
Message-ID: <20071119162307.GI6212@lavos.net>
In-Reply-To: <alpine.LFD.0.99999.0711191049440.19105@xanadu.home>

On Mon, Nov 19, 2007 at 10:51:31AM -0500, Nicolas Pitre wrote:

Show 5 quoted lines

> > * Explain that the default of core.compression is -1, zlib default, and
> >   add a quote from zlib.h explaining what that actually means.
> 
> No, this is wrong.  core.compression has no default.  It is meaningful 
> only when an explicit value is configured.

Would you prefer this?

       If not set, packs will be compressed to the zlib default level,
       which is "a default compromise between speed and compression
       (currently equivalent to level 6)."

I'm trying to make it reassuring as to the fact that, "yes, packs are compressed plenty, you really don't need to mess with this unless you want to." As it stands I could see the potential confusion that no (or poor) compression will occur in packs unless this is set.

-bcd