Re: Something is broken in repack

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Dec 8, 2007, 00:37 UTC
Message-ID: <alpine.LFD.0.9999.0712071632490.12046@woody.linux-foundation.org>
In-Reply-To: <9e4733910712071505y6834f040k37261d65a2d445c4@mail.gmail.com>

On Fri, 7 Dec 2007, Jon Smirl wrote:

Show 5 quoted lines

>
> Using this config:
> [pack]
>         threads = 4
>         deltacachesize = 256M

I think deltacachesize is broken.

The code in try_delta() that replaces a delta cache entry with another one seems very buggy wrt that whole "delta_cache_size" update. It does

	delta_cache_size -= trg_entry->delta_size;

to account for the old delta going away, but it does this *after* having already replaced trg_entry->delta_size with the new delta entry.

I suspect there are other issues going on too, but that's the one that I noticed from a quick look-through.

Nico? I think this one is yours..

		Linus