Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'
- From
Nicolas Pitre <nico@cam.org>
- Date
- Oct 19, 2007, 03:01 UTC
- Message-ID
- <alpine.LFD.0.9999.0710182251110.19446@xanadu.home>
- In-Reply-To
- <20071019023425.GB8298@coredump.intra.peff.net>
On Thu, 18 Oct 2007, Jeff King wrote:
Show 10 quoted lines
> On a similar note, some complaints with progress meters, even after > recent patches: > - When fetching, one progress meter says "Indexing" which, while > technically true, is almost certainly blocking on "Downloading". In > fact, it is not clear from the existing messages exactly _when_ we > are downloading, and when we are just computing, which is something > I think a user might want to know. Objections to changing this > (though perhaps index-pack will need to be told when it is > downloading and when it is just indexing)? Objections to a > throughput indicator?
I have some WIP for that.
Show 11 quoted lines
> - Running git-gc, we now get something like: > Counting objects: 62317, done. > Deltifying objects: 100% (18042/18042), done. > Writing objects: 100% (62317/62317), done. > Total 62317 (delta 43861), reused 61404 (delta 43036) > Pack pack-32f8ac40c1a5ec146e45c657cb16f53fdd354095 created. > Removing unused objects 100%... > Done. > Can we get rid of total statistics (I think this is useful for some > power users, but perhaps there should be a verbosity level), the > name of the pack file (same deal), and the totally useless "Done."?
Agreed for the pack name. Certainly no one cares.
Maybe the "Removing unused objects" should use the common progress infrastructure? It could even use the delayed interface, just like when checking out files, so no progress at all is displayed when that operation completes within a certain delay. And the removal of unused objects is usually quick.
But I like the statistics. They might be pretty handy to diagnoze performance issues on remote servers for example.
Nicolas