Re: [PATCH] Change 'Deltifying objects' to 'Delta compressing objects'
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Oct 19, 2007, 19:00 UTC
- Message-ID
- <alpine.LFD.0.999.0710191157560.26902@woody.linux-foundation.org>
- In-Reply-To
- <alpine.LFD.0.9999.0710190753040.19446@xanadu.home>
On Fri, 19 Oct 2007, Nicolas Pitre wrote:
Show 9 quoted lines
> On Fri, 19 Oct 2007, Jeff King wrote:
> >
> > Ah, right. I hadn't thought of that. While it would be a nice
> > convenience feature, it's probably not worth the deep internal hackery
> > that would be required.
>
> What about a preprocessor that could match <1>@{<2>..<3>} in the
> argument list and substitute that with <1>@{<2>}..<1>@{<3>} before it is
> actually parsed?Could be done, but I almost think it would be better to just make the sha1_name.c interfaces take some extended data structure which allows looking up multiple SHA1's at the same time.
Sure, we'd leave the "simple" interfaces around for users that simply want just one SHA1 value, but that would allow us to remove duplicate code from revision.c and rev-parse.c. And it would allow us to generally make the SHA1 parsing fancier: there may well be other expressions that are worth doing.
Linus