Re: [PATCH/RFC 0/3] faster inexact rename handling
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Oct 30, 2007, 05:06 UTC
- Message-ID
- <alpine.LFD.0.999.0710292156580.30120@woody.linux-foundation.org>
- In-Reply-To
- <20071030042118.GA14729@sigill.intra.peff.net>
On Tue, 30 Oct 2007, Jeff King wrote:
Show 6 quoted lines
> > - no improvement on smaller datasets. Running "git-whatchanged -M > --raw -l0" on the linux-2.6 repo takes about the same time with the > old and new code (presumably the algorithmic savings of the new code > are lost in a higher constant factor, so when n is small, it is a > wash).
Have you compared the results? IOW, does it find the *same* renames?
I'm a bit worried about the fact that you just pick a single (arbitrary) src/dst per fingerprint. Yes, it should be limited, but that seems to be a bit too *extremely* limited. But if it gives the same results in practice, maybe nobody cares?
Linus