Re: gitk from subdirectory

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Aug 31, 2007, 05:08 UTC
Message-ID: <alpine.LFD.0.999.0708302200160.25853@woody.linux-foundation.org>
In-Reply-To: <7vabs85ntg.fsf@gitster.siamese.dyndns.org>

On Thu, 30 Aug 2007, Junio C Hamano wrote:

Show 6 quoted lines

> 
> I am wondering if this was intended behaviour change.  I think
> it makes sense to want an easy way to say "what changed stuff in
> the directory I am in?" because presumably you are there because
> you are interested in stuff in there.  But if you hard code "--"
> it is not easy to disable that and get the global log.

Hmm. My reaction to this would be that it was a mistake to have a difference between

	git log --

and

	git log

and that we should instead fix this at the argument parsing level.

And then anybody who depended on the old "--" behaviour can just add a "." at the end.

That way there are no special cases.

I realize that the "--" behaviour of git log was intentional, but seeing what it results in I think the intention was good, but stupid.

		Linus